add popover API #19328
Merged
add popover API #19328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
data:api 🐇
Elchi3
requested changes
Apr 11, 2023
There was a problem hiding this comment.
Thanks for your PR! I think the CI failure is because we want multipage/ links to the HTML spec.
Chrome 114 is correct according to https://chromestatus.com/feature/5463833265045504
Co-authored-by: Florian Scholz <[email protected]>
Elchi3
reviewed
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds all of the API for global attributes and properties with relation to the Popover API. I worked on this mostly to get the ball rolling. Chrome 114 is slated to ship this but it has not definitely shipped to a browser.
Test results and supporting details
These are available in the specification: https://html.spec.whatwg.org/#the-popover-attribute
Related issues
mdn/content#25125