Update early support for CanvasGradient and CanvasPattern #17794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for CanvasPattern is implied by support for ctx.createPattern(), since that's how a CanvasPattern instance is created. Similarly, support for CanvasGradient is implied by support for either createLinearGradient() or createRadialGradient(). The support data for CanvasRenderingContext2D looks reliable based on the PRs that updated it to the current state: mdn#7465 mdn#8666 Update CanvasGradient and CanvasPattern to match. The versions now match for all browsers except Opera, where some ≤12.1 versions were left alone rather than trying to confirm the correct versions.
github-actions
bot
added
the
data:api 🐇
foolip
commented
Sep 14, 2022
| @@ -6,7 +6,7 @@ | |||
| "spec_url": "https://html.spec.whatwg.org/multipage/canvas.html#canvasgradient", | |||
| "support": { | |||
| "chrome": { | |||
| "version_added": "6" | |||
| "version_added": "1" | |||
There was a problem hiding this comment.
I'm hoping this will be confirmed by foolip/mdn-bcd-collector#2334 but I don't have Chrome 1 to test with myself.
lucalves
approved these changes
Sep 19, 2022
queengooborg
approved these changes
Sep 19, 2022
foolip
added a commit
to foolip/browser-compat-data
that referenced
this pull request
Sep 21, 2022
This revisits cases of Safari 5.1 + iOS 6 in the data preserved here: mdn#17772 All features touched there are accounted for in the following... CanvasGradient was fixed in these PRs: mdn#17794 mdn#17843 api.HTMLMarqueeElement.*, WebKit version 534.14: mdn#17011 api.HashChangeEvent.*, WebKit version 534.9: WebKit/WebKit@a3f483b https://github.com/WebKit/WebKit/blob/a3f483bbf1936c76f44387cde8fac903a86e69d0/WebCore/Configurations/Version.xcconfig api.Window.error_event: mdn#13053 css.properties.border-radius.percentages, WebKit version 534.7: WebKit/WebKit@1c44c69 https://github.com/WebKit/WebKit/blob/1c44c69b77bddd43c8f5786fc27369cae9b9d3b2/WebCore/Configurations/Version.xcconfig css.properties.hyphens.english was previously mirrored: mdn#4636 css.selectors.left/right, WebKit 533.7? mdn#4448 css.types.image.gradient.linear-gradient/radial-gradient, WebKit 534.16: WebKit/WebKit@68c9486 https://github.com/WebKit/WebKit/blob/68c9486e0c50d5e468c9473685824b50d54ef15e/WebCore/Configurations/Version.xcconfig css.types.image.gradient.repeating-linear-gradient/repeating-radial-gradient, WebKit 534.16: WebKit/WebKit@b03353e https://github.com/WebKit/WebKit/blob/b03353e8249b7a3a50cc42173bb4c8d6ea733ef3/WebCore/Configurations/Version.xcconfig javascript.builtins.ArrayBuffer.slice: mdn#17717 (comment) javascript.builtins.Function.bind: mdn#347 javascript.builtins.Object.freeze javascript.builtins.Object.isExtensible javascript.builtins.Object.isFrozen javascript.builtins.Object.isSealed javascript.builtins.Object.preventExtensions javascript.builtins.Object.seal javascript.statements.const
foolip
added a commit
to foolip/browser-compat-data
that referenced
this pull request
Sep 21, 2022
This revisits cases of Safari 5.1 + iOS 6 in the data preserved here: mdn#17772 All features touched there are accounted for in the following... Handled in other PRs ==================== api.CanvasGradient: mdn#17794 mdn#17843 css.selectors.left/right: mdn#17852 Confirmed via source ==================== These features were confirmed to map to Safari 5.1 / iOS 5 via source, landing in WebKit versions 534.7 through 534.16. api.HTMLMarqueeElement, WebKit version 534.14: mdn#17011 api.HashChangeEvent, WebKit version 534.9: WebKit/WebKit@a3f483b https://github.com/WebKit/WebKit/blob/a3f483bbf1936c76f44387cde8fac903a86e69d0/WebCore/Configurations/Version.xcconfig css.properties.border-radius.percentages, WebKit version 534.7: WebKit/WebKit@1c44c69 https://github.com/WebKit/WebKit/blob/1c44c69b77bddd43c8f5786fc27369cae9b9d3b2/WebCore/Configurations/Version.xcconfig css.types.image.gradient.linear-gradient/radial-gradient, WebKit 534.16: WebKit/WebKit@68c9486 https://github.com/WebKit/WebKit/blob/68c9486e0c50d5e468c9473685824b50d54ef15e/WebCore/Configurations/Version.xcconfig css.types.image.gradient.repeating-linear-gradient/repeating-radial-gradient, WebKit 534.16: WebKit/WebKit@b03353e https://github.com/WebKit/WebKit/blob/b03353e8249b7a3a50cc42173bb4c8d6ea733ef3/WebCore/Configurations/Version.xcconfig Confirmed with testing ====================== api.Window.error_event: http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=10758 was run in iOS 4.2 and 5 to confirm iOS 5 is correct. Adapted from the test in the PR that last updated this data: mdn#13053 Previously mirrored =================== These features were previously mirrored, so the choice of iOS 6 was not deliberate. css.properties.hyphens.english: mdn#4636 javascript.builtins.Object.freeze, javascript.builtins.Object.isExtensible, javascript.builtins.Object.isFrozen, javascript.builtins.Object.isSealed, javascript.builtins.Object.preventExtensions, javascript.builtins.Object.seal, javascript.statements.const: mdn#5483 Backported to Safari 5.1 ======================== A bunch of JSC changes were backported to the Safari 5.1 release branch. It's hard to determine if these were also backported to any iOS 5 release, so these are left as 5.1/6 pairs. javascript.builtins.ArrayBuffer.slice: mdn#17717 (comment) javascript.builtins.Function.bind: WebKit/WebKit@ec2129f WebKit/WebKit@bb7691c
foolip
added a commit
to foolip/browser-compat-data
that referenced
this pull request
Sep 21, 2022
This revisits cases of Safari 5.1 + iOS 6 in the data preserved here: mdn#17772 All features touched there are accounted for in the following... Handled in other PRs ==================== api.CanvasGradient: mdn#17794 mdn#17843 css.selectors.left/right: mdn#17852 Confirmed via source ==================== These features were confirmed to map to Safari 5.1 / iOS 5 via source, landing in WebKit versions 534.7 through 534.16. api.HTMLMarqueeElement, WebKit version 534.14: mdn#17011 api.HashChangeEvent, WebKit version 534.9: WebKit/WebKit@a3f483b https://github.com/WebKit/WebKit/blob/a3f483bbf1936c76f44387cde8fac903a86e69d0/WebCore/Configurations/Version.xcconfig css.properties.border-radius.percentages, WebKit version 534.7: WebKit/WebKit@1c44c69 https://github.com/WebKit/WebKit/blob/1c44c69b77bddd43c8f5786fc27369cae9b9d3b2/WebCore/Configurations/Version.xcconfig css.types.image.gradient.linear-gradient/radial-gradient, WebKit 534.16: WebKit/WebKit@68c9486 https://github.com/WebKit/WebKit/blob/68c9486e0c50d5e468c9473685824b50d54ef15e/WebCore/Configurations/Version.xcconfig css.types.image.gradient.repeating-linear-gradient/repeating-radial-gradient, WebKit 534.16: WebKit/WebKit@b03353e https://github.com/WebKit/WebKit/blob/b03353e8249b7a3a50cc42173bb4c8d6ea733ef3/WebCore/Configurations/Version.xcconfig Confirmed with testing ====================== api.Window.error_event: http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=10758 was run in iOS 4.2 and 5 to confirm iOS 5 is correct. Adapted from the test in the PR that last updated this data: mdn#13053 Previously mirrored =================== These features were previously mirrored, so the choice of iOS 6 was not deliberate. css.properties.hyphens.english: mdn#4636 javascript.builtins.Object.freeze, javascript.builtins.Object.isExtensible, javascript.builtins.Object.isFrozen, javascript.builtins.Object.isSealed, javascript.builtins.Object.preventExtensions, javascript.builtins.Object.seal, javascript.statements.const: mdn#5483 Backported to Safari 5.1 ======================== A bunch of JSC changes were backported to the Safari 5.1 release branch. It's hard to determine if these were also backported to any iOS 5 release, so these are left as 5.1/6 pairs. javascript.builtins.ArrayBuffer.slice: mdn#17717 (comment) javascript.builtins.Function.bind: WebKit/WebKit@ec2129f WebKit/WebKit@bb7691c
queengooborg
pushed a commit
that referenced
this pull request
Sep 21, 2022
This revisits cases of Safari 5.1 + iOS 6 in the data preserved here: #17772 All features touched there are accounted for in the following... Handled in other PRs ==================== api.CanvasGradient: #17794 #17843 css.selectors.left/right: #17852 Confirmed via source ==================== These features were confirmed to map to Safari 5.1 / iOS 5 via source, landing in WebKit versions 534.7 through 534.16. api.HTMLMarqueeElement, WebKit version 534.14: #17011 api.HashChangeEvent, WebKit version 534.9: WebKit/WebKit@a3f483b https://github.com/WebKit/WebKit/blob/a3f483bbf1936c76f44387cde8fac903a86e69d0/WebCore/Configurations/Version.xcconfig css.properties.border-radius.percentages, WebKit version 534.7: WebKit/WebKit@1c44c69 https://github.com/WebKit/WebKit/blob/1c44c69b77bddd43c8f5786fc27369cae9b9d3b2/WebCore/Configurations/Version.xcconfig css.types.image.gradient.linear-gradient/radial-gradient, WebKit 534.16: WebKit/WebKit@68c9486 https://github.com/WebKit/WebKit/blob/68c9486e0c50d5e468c9473685824b50d54ef15e/WebCore/Configurations/Version.xcconfig css.types.image.gradient.repeating-linear-gradient/repeating-radial-gradient, WebKit 534.16: WebKit/WebKit@b03353e https://github.com/WebKit/WebKit/blob/b03353e8249b7a3a50cc42173bb4c8d6ea733ef3/WebCore/Configurations/Version.xcconfig Confirmed with testing ====================== api.Window.error_event: http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=10758 was run in iOS 4.2 and 5 to confirm iOS 5 is correct. Adapted from the test in the PR that last updated this data: #13053 Previously mirrored =================== These features were previously mirrored, so the choice of iOS 6 was not deliberate. css.properties.hyphens.english: #4636 javascript.builtins.Object.freeze, javascript.builtins.Object.isExtensible, javascript.builtins.Object.isFrozen, javascript.builtins.Object.isSealed, javascript.builtins.Object.preventExtensions, javascript.builtins.Object.seal, javascript.statements.const: #5483 Backported to Safari 5.1 ======================== A bunch of JSC changes were backported to the Safari 5.1 release branch. It's hard to determine if these were also backported to any iOS 5 release, so these are left as 5.1/6 pairs. javascript.builtins.ArrayBuffer.slice: #17717 (comment) javascript.builtins.Function.bind: WebKit/WebKit@ec2129f WebKit/WebKit@bb7691c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for CanvasPattern is implied by support for ctx.createPattern(),
since that's how a CanvasPattern instance is created. Similarly, support
for CanvasGradient is implied by support for either
createLinearGradient() or createRadialGradient().
The support data for CanvasRenderingContext2D looks reliable based on
the PRs that updated it to the current state:
#7465
#8666
Update CanvasGradient and CanvasPattern to match. The versions now match
for all browsers except Opera, where some ≤12.1 versions were left alone
rather than trying to confirm the correct versions.