Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec-url for spread syntax itself #17328

Merged
merged 2 commits into from
Aug 14, 2022
Merged

Conversation

Josh-Cena
Copy link
Member

Summary

Fix #12701
Fix #14392

Test results and supporting details

Related issues

@github-actions github-actions bot added the data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript label Aug 12, 2022
Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <[email protected]>
Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fixes! This is LGTM!

@queengooborg queengooborg enabled auto-merge (squash) August 14, 2022 06:11
@Josh-Cena
Copy link
Member Author

@queengooborg Do you think it actually makes sense to have __compat for spread itself? We are kind of conflating three features into one in the first place.

@queengooborg queengooborg merged commit 83563fa into mdn:main Aug 14, 2022
@Josh-Cena Josh-Cena deleted the fix-spread branch August 14, 2022 06:14
@queengooborg
Copy link
Collaborator

I think so, since it helps maintain parity with the MDN pages and structural continuity with other BCD features. We do have subfeatures for each meaning of the spread syntax, though!

@Josh-Cena
Copy link
Member Author

I see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript
Projects
None yet
2 participants