Fix Safari support for sizes/srcset attributes/properties #16961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The <picture> element was in WebKit trunk version 602.1.14: WebKit/WebKit@ee1f266 https://github.com/WebKit/WebKit/blob/ee1f2663e07eb21f6ea8e0b0d01fce127d66e9a7/Source/WebCore/Configurations/Version.xcconfig The reflected properties were in WebKit trunk version 603.1.6: WebKit/WebKit@96c370b https://github.com/WebKit/WebKit/blob/96c370b3601a5427ba1a4dd2ef78657d59729721/Source/WebCore/Configurations/Version.xcconfig Add notes to reflect the discrepancy, in case we try to merge attributes and reflected properties in the future.
github-actions
bot
added
data:api
queengooborg
requested changes
Jul 13, 2022
Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <[email protected]>
queengooborg
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
<picture>element was in WebKit trunk version 602.1.14:WebKit/WebKit@ee1f266
https://github.com/WebKit/WebKit/blob/ee1f2663e07eb21f6ea8e0b0d01fce127d66e9a7/Source/WebCore/Configurations/Version.xcconfig
The reflected properties were in WebKit trunk version 603.1.6:
WebKit/WebKit@96c370b
https://github.com/WebKit/WebKit/blob/96c370b3601a5427ba1a4dd2ef78657d59729721/Source/WebCore/Configurations/Version.xcconfig
Add notes to reflect the discrepancy, in case we try to merge attributes
and reflected properties in the future.