Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler global property #16409

Merged
merged 1 commit into from
May 31, 2022
Merged

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented May 24, 2022

The prioritised scheduling API was mostly present in BCD and I added FF101 updates in #16177.

BUT, access to the API is via the scheduler property on the global object - e.g. this or window on main thread. This adds BCD entry for the global scheduler.

@queengooborg Question for you. The spec actually adds this to WindowOrWorderGlobalScope mixin which we don't document. One place obviously that goes is Window (as documented here). But where do I add the worker entries both for BCD and docs - this could be the top level scope objects (all of them) or somewhere else. Advice appreciated!

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label May 24, 2022
@queengooborg
Copy link
Collaborator

Things added to WindowOrWorkerGlobalScope should actually be added under _globals as per https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#global-apis, would you mind putting it there?

@hamishwillee hamishwillee changed the title Window.scheduler scheduler global property May 27, 2022
@hamishwillee
Copy link
Collaborator Author

@queengooborg Thanks. Fixed! Also added myself a note to check the data guidelines next time I get stuck. Ready for re-review.

@queengooborg queengooborg merged commit feb1813 into mdn:main May 31, 2022
@hamishwillee hamishwillee deleted the window_scheduler branch June 3, 2022 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants