Add consistent copyright notice + use strict to all JS+TS files #15917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bulk_update 📦
|
In #12161 (comment), @caugner pointed out that ES modules are implicitly strict (and some quick research confirms this). Should we remove the |
|
@queengooborg how about removing them after the conversion, or as part of it? |
|
This pull request has merge conflicts that must be resolved before we can merge this. |
|
@schalkneethling Would you mind reviewing this PR? |
Funny you should ask 😸 - I just learned about this new "standard"/tool from the Free software foundation https://reuse.software - Not saying we should immediately adopt it here, but surely something to consider. |
schalkneethling
approved these changes
May 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a cherry-pick of #5890 that makes the top of our files consistent by performing the following:
#!lines from all the files (they were added to non-executable files as well and don't help since the files aren't marked executable anyways)'use strict'to all filesFixes #5879.