Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linter for incorrect feature statuses #15889

Merged
merged 37 commits into from
Jun 13, 2022

Conversation

queengooborg
Copy link
Contributor

@queengooborg queengooborg commented Apr 19, 2022

This PR builds on #6813 that starts cherry-pick from #11430 and fixes #6812 to add more status tests, enforcing the following:

  • Standard track must be true if there is a spec URL
  • Experimental must be false if a feature is supported in multiple browser engines

This PR also performs the fix using the provided fix script.

@github-actions github-actions bot added linter Issues or pull requests regarding the tests / linter of the JSON files. scripts Issues or pull requests regarding the scripts in scripts/. labels Apr 19, 2022
Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bunch of comments here would apply to all lint code. If you think they make sense but don't want to fix it now, can you file issues?

scripts/fix-status.js Outdated Show resolved Hide resolved
scripts/fix-status.js Outdated Show resolved Hide resolved
scripts/fix-status.js Outdated Show resolved Hide resolved
scripts/fix-status.js Outdated Show resolved Hide resolved
scripts/fix-status.js Outdated Show resolved Hide resolved
scripts/fix-status.js Outdated Show resolved Hide resolved
test/linter/test-status.js Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented May 7, 2022

This pull request has merge conflicts that must be resolved before we can merge this.

1 similar comment
@github-actions
Copy link

github-actions bot commented May 7, 2022

This pull request has merge conflicts that must be resolved before we can merge this.

@github-actions
Copy link

This pull request has merge conflicts that must be resolved before we can merge this.

2 similar comments
@github-actions
Copy link

This pull request has merge conflicts that must be resolved before we can merge this.

@github-actions
Copy link

This pull request has merge conflicts that must be resolved before we can merge this.

@github-actions
Copy link

This pull request has merge conflicts that must be resolved before we can merge this.

@github-actions
Copy link

This pull request has merge conflicts that must be resolved before we can merge this.

@github-actions
Copy link

github-actions bot commented Jun 1, 2022

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jun 13, 2022
@queengooborg queengooborg merged commit 4c465c6 into mdn:main Jun 13, 2022
@queengooborg queengooborg deleted the linter/test-status branch June 13, 2022 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API linter Issues or pull requests regarding the tests / linter of the JSON files. scripts Issues or pull requests regarding the scripts in scripts/.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove status.experimental when nonstandard/deprecated
3 participants