Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "matches" object from schema #15781

Merged
merged 8 commits into from
May 26, 2022
Merged

Remove "matches" object from schema #15781

merged 8 commits into from
May 26, 2022

Conversation

queengooborg
Copy link
Collaborator

@queengooborg queengooborg commented Apr 12, 2022 •
edited
Loading

This PR removes the matches object from the schema. The feature is hardly used anywhere other than a few CSS properties and has not been maintained. On top of it, the linter to verify matches regexes was never actually integrated into the linter run.

Note: in regards to the transform CSS property, I'm thinking that we should separate the keywords out, but I'm not fully certain on that.

Fixes #8945.

@github-actions github-actions bot added data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS docs ✍️ Issues or pull requests regarding the documentation of this project. linter 🏡 Issues or pull requests regarding the tests / linter of the JSON files. schema ⚙️ Isses or pull requests regarding the JSON schema files used in this project. labels Apr 12, 2022
@ddbeck ddbeck removed their request for review April 13, 2022 08:17
@queengooborg queengooborg mentioned this pull request Apr 18, 2022
Closed
@Elchi3 Elchi3 mentioned this pull request Apr 19, 2022
Closed
Elchi3
Elchi3 requested changes Apr 21, 2022
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r- here until webhintio/hint#5126 is solved on the webhintio side.

@queengooborg queengooborg added not ready ⛔ This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. semver-major-bump 🚨 A change that is potentially breaking for consumers labels Apr 22, 2022
@github-actions
Copy link

github-actions bot commented May 8, 2022

This pull request has merge conflicts that must be resolved before we can merge this.

@github-actions
Copy link

This pull request has merge conflicts that must be resolved before we can merge this.

caugner
caugner approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@caugner caugner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but ⚠️ major bump

edit: And there was the concern about webhintio/hint#5126.

@queengooborg queengooborg mentioned this pull request May 17, 2022
Merged
@github-actions
Copy link

This pull request has merge conflicts that must be resolved before we can merge this.

@github-actions
Copy link

This pull request has merge conflicts that must be resolved before we can merge this.

@github-actions
Copy link

This pull request has merge conflicts that must be resolved before we can merge this.

@queengooborg queengooborg mentioned this pull request May 21, 2022
Closed
@antross
Copy link
Contributor

antross commented May 26, 2022

@queengooborg @Elchi3 @caugner, we've finished preparing for this removal on the webhint side. Feel free to move forward and thanks for giving us the heads-up + some time to adapt before this went in! 😊

@queengooborg
Copy link
Collaborator Author

Thanks @antross for the notice!

@queengooborg queengooborg merged commit 237a32a into mdn:main May 26, 2022
@queengooborg queengooborg deleted the schema/matches branch May 26, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 requested changes

@caugner caugner caugner approved these changes

Assignees
No one assigned
Labels
data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS docs ✍️ Issues or pull requests regarding the documentation of this project. linter 🏡 Issues or pull requests regarding the tests / linter of the JSON files. not ready ⛔ This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. schema ⚙️ Isses or pull requests regarding the JSON schema files used in this project. semver-major-bump 🚨 A change that is potentially breaking for consumers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove "matches" object from schema
4 participants
@queengooborg @antross @Elchi3 @caugner