-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add __meta property to BCD build #14129
Add __meta property to BCD build #14129
Conversation
This change is not without risk and I think would require at least a minor version bump. I am fairly skeptical of making this change unless there are multiple requests from BCD consumers. |
I think that we should include this in a major semver bump actually, since it is a potentially breaking change. In doing so, however, this might help our consumers understand that keys starting with I think if we are to do this, we should land it around the same time we start releasing ESM builds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but ...
- ... wouldn't it make sense to wrap the version in a
__meta
object (with one keyversion
), so that we can extend this in the future? - ... this is probably a breaking change for consumers that just loop over the data (and this makes me wonder if we have other breaking changes in the pipeline - possibly among your open PRs - that should be bundled with this).
This pull request has merge conflicts that must be resolved before we can merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request has merge conflicts that must be resolved before we can merge this. |
I'm going to hold off on merging this for the time being since it is a major semver bump. I'd like to get other changes merged alongside this one before the next release. |
@queengooborg Would it make sense to create a |
Maybe so, yeah -- my plan was originally to hold off on a v5 release until #16232 is merged (and maybe the ESM internal upgrades), but also to hold off so we get a v4.2.0 release... :D |
This PR fixes #7358 by adding a
__meta
property to the BCD root, containing the build's version number. This allows for easier access of the version number for NodeJS users, and straight-up allows access for Deno/browser/Python/etc. users entirely.