Diff features by fetching from GitHub Actions #13720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This substantially speeds up feature diffing, where the enumeration has already been done in GitHub Actions. Where possible, it trys to fetch from GitHub Actions, or falls back to using a worktree to enumerate directly. See mdn#13695 for background.
github-actions
bot
added
the
scripts
Elchi3
approved these changes
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This substantially speeds up feature diffing, where the enumeration has already been done in GitHub Actions. Where possible, it tries to fetch from GitHub Actions, or falls back to using a worktree to enumerate directly.
Test results and supporting details
You can see this in action with these examples:
node ./scripts/diff-features.js --format=json 80d976fb46e5ca453856adcab9bcf0b36a4bf140, for a fallback case. This is typical for commits older than about 24 hours. On my machine, runs in about 10 seconds (with a full npm cache).node ./scripts/diff-features.js --format=json 1409a8c6d17e7d420404bb1a0561cca431cba1b5, for a GitHub-facilitated case. Runs in about 5 seconds.Related issues
See #13695 for background.