Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shadowroot attribute to template element. #13230

Merged
merged 2 commits into from
Nov 22, 2021
Merged

Add shadowroot attribute to template element. #13230

merged 2 commits into from
Nov 22, 2021

Conversation

jpmedley
Copy link
Contributor

@jpmedley jpmedley commented Nov 1, 2021

Summary

Adds shadowroot attribute to <template> element.

Test results and supporting details

https://www.chromestatus.com/features/5191745052606464

Related issues

Part 1 of fixing mdn/content#9559

@github-actions github-actions bot added the data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label Nov 1, 2021
@jpmedley
Copy link
Contributor Author

jpmedley commented Nov 2, 2021

@queengooborg @Elchi3

I would appreciate some help. I don't see why this is failing.

@Elchi3
Copy link
Member

Elchi3 commented Nov 2, 2021

You're missing a "__compat" property. It is always required

@jpmedley
Copy link
Contributor Author

jpmedley commented Nov 2, 2021

Thanks.

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes now, thanks!

@Elchi3 Elchi3 merged commit ab56e78 into main Nov 22, 2021
@Elchi3 Elchi3 deleted the shadowroot branch November 22, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants