Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chrome/Safari versions for api.Range.insertNode.collapsed_ranges #13075

Merged

Conversation

queengooborg
Copy link
Contributor

@queengooborg queengooborg commented Oct 24, 2021

This PR adds real values for Chrome and Safari for the insertNode.collapsed_ranges member of the Range API, based upon commit history and date.

Commit: https://source.chromium.org/chromium/chromium/src/+/93dc784929a88c3a7ed460e20dc7f00d14234b42 (WebKit 526.1.0)

This PR adds real values for Chrome and Safari for the `insertNode.collapsed_ranges` member of the `Range` API, based upon commit history and date.

Commit: https://source.chromium.org/chromium/chromium/src/+/93dc784929a88c3a7ed460e20dc7f00d14234b42
@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Oct 24, 2021
@foolip
Copy link
Contributor

foolip commented Oct 28, 2021

What does this entry mean? Without knowing what "collapsed ranges" for insertNode() means, I don't know how to verify this. Judging by the current data, it's about something that changed in Firefox 14. I would not be surprised if it turns out to be something minor and we should remove this entry instead.

@jpmedley jpmedley merged commit 969d962 into mdn:main Oct 28, 2021
@queengooborg queengooborg deleted the api/Range/insertNode/collapsed_ranges/webkit branch October 28, 2021 18:33
@queengooborg
Copy link
Contributor Author

When I was researching this, I was assuming that the subfeature was referring to step 13 in the steps to insertNode: https://dom.spec.whatwg.org/#ref-for-range-collapsed%E2%91%A4

I realize I should've linked this in the PR description, my bad!

foolip added a commit to foolip/browser-compat-data that referenced this pull request Nov 10, 2021
It's not clear what this sub-feature means from just the description,
and all we have is a guess:
mdn#13075 (comment)

The data matches the parent feature except for Firefox and Safari. This
probably means there's *something* that doesn't work the same before
Firefox 14 and Safari 4. This is far enough in the past that it's not
worth trying to salvage this sub-feature with more research.
Elchi3 pushed a commit that referenced this pull request Nov 15, 2021
It's not clear what this sub-feature means from just the description,
and all we have is a guess:
#13075 (comment)

The data matches the parent feature except for Firefox and Safari. This
probably means there's *something* that doesn't work the same before
Firefox 14 and Safari 4. This is far enough in the past that it's not
worth trying to salvage this sub-feature with more research.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants