Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove api.XMLHttpRequest.readyState.constants from BCD #12879

Merged

Conversation

queengooborg
Copy link
Contributor

@queengooborg queengooborg commented Oct 15, 2021

This PR removes the `readyState.constants` member of the `XMLHttpRequest` API from BCD.  This feature is a dictionary, enum, or WebIDL typedef and should not be included in BCD.
@queengooborg queengooborg added needs-release-note 📰 needs content update This PR needs a corresponding update to mdn/content to update the documentation labels Oct 15, 2021
@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Oct 15, 2021
@foolip
Copy link
Contributor

foolip commented Nov 10, 2021

@queengooborg there's a conflict to resolve here.

@queengooborg queengooborg removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Nov 10, 2021
@queengooborg
Copy link
Contributor Author

Realizing we don't need to make any content updates for this removal!

@foolip
Copy link
Contributor

foolip commented Nov 12, 2021

This feature is a dictionary, enum, or WebIDL typedef and should not be included in BCD.

I saw about to merge when I noticed this description isn't right. The reason this should be removed is https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#constants.

@foolip foolip merged commit c090323 into mdn:main Nov 12, 2021
@queengooborg queengooborg deleted the api/XMLHttpRequest/readyState/constants/removal branch November 12, 2021 10:55
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Nov 16, 2021
ddbeck added a commit that referenced this pull request Nov 16, 2021
* Bump version to v4.0.11

* Add release date

* Add release note for #12879

* Add release note for #13424

* Add release note for #13479

* Add release note for #13486

* Add release note for #13523

* Hoist from previous release

* Add stats

* Copyedit

* Fix order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants