Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds missing property and method, plus URLs to NavigatorUAData #11800

Closed
wants to merge 1 commit into from

Conversation

rachelandrew
Copy link
Collaborator

Working on NavigatorUAData for the User-Agent Client Hints API in mdn/content#7280

There has been an additional property platform added to the spec, and in development in Chromium, also a toJSON() method. This PR adds those, plus the spec and MDN URLs.

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jul 27, 2021
@jpmedley
Copy link
Contributor

@vinyldarkscratch Can you please look at this soon. We're about to merge the pages this relates to.

@queengooborg queengooborg self-requested a review July 29, 2021 22:38
@queengooborg
Copy link
Contributor

Although we're still coming to a decision in #10619, it seems that overall the top vote is to allow all-false rows with a link to an open bug (or ChromeStatus link). Still, I don't feel comfortable in merging this PR until we've decided how to handle all-false rows. I'll mark this as "not ready" for the time being.

If you'd like to cherry-pick the spec URL additions into their own PR, I'd be happy to merge that right away!

@queengooborg queengooborg added the not ready This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. label Jul 30, 2021
@queengooborg queengooborg removed their request for review August 22, 2021 12:29
@Elchi3
Copy link
Member

Elchi3 commented Apr 1, 2022

#13465 and #14288 completed this. Closing here.

@Elchi3 Elchi3 closed this Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API not ready This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants