Remove irrelevant api.Document.loadOverlay #11720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds real values for for the `loadOverlay` member of the `Document` API, based upon results from the [mdn-bcd-collector](https://mdn-bcd-collector.appspot.com) project (v3.2.2). Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/Document/loadOverlay
queengooborg
added
needs-release-note 📰
needs content update
github-actions
bot
added
the
data:api
queengooborg
changed the title
queengooborg
removed
the
needs content update
|
It appears the documentation has already been removed as well before writing this PR! |
foolip
approved these changes
Jul 24, 2021
| @@ -6940,69 +6940,6 @@ | |||
| } | |||
| } | |||
| }, | |||
| "loadOverlay": { | |||
| "__compat": { | |||
| "mdn_url": "https://developer.mozilla.org/docs/Web/API/Document/loadOverlay", | |||
There was a problem hiding this comment.
| "firefox": [ | ||
| { | ||
| "version_added": true, | ||
| "version_removed": "61", |
There was a problem hiding this comment.
Firefox 61 was shipped in 2018-06-26, more than 2 years ago 👍
ddbeck
added a commit
to ddbeck/browser-compat-data
that referenced
this pull request
Jul 29, 2021
ddbeck
added a commit
that referenced
this pull request
Jul 29, 2021
* Bump version to v3.3.13 * Add release note for #11717 * Add release note for #11753 * Add release note for #11459 * Add release note for #11720 * Add release note for #11722 * Add release note for #11721 * Add release note for #11763 * Add release note for #10623 * Add release note for #11000 * Add stats and release date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the irrelevant
loadOverlaymember of theDocumentAPI as per the corresponding data guidelines. The lack of current support has been confirmed by the mdn-bcd-collector project (v3.2.2), even if the current BCD suggests support.