-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds spec data to MIDI interfaces #11505
Conversation
Excellent! I can review this.
Unfortunately support of events is a bit of a mess in BCD, with #7545 describing the current state of things with no clear conclusion for how to improve it. We have lots of APIs with both |
api/MIDIAccess.json
Outdated
@@ -191,58 +195,10 @@ | |||
} | |||
} | |||
}, | |||
"statechange_event": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep this entry. Unfortunately there's nothing to link to in the spec, the "event itself" (as opposed to the onstatechange
property) only shows up as that "statechange" string in step 3 of the algorithm in https://webaudio.github.io/web-midi-api/#dom-midiaccess-onstatechange.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just re-added that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I found another thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rachelandrew for your patience!
Adds spec URLs to the MIDI interfaces as I'm creating the documentation pages.
I also removed a duplicate statechange event from MIDIAccess, as this seemed to be a duplicate of onstatechange.