Update parameter entries to match guidelines #11080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api
queengooborg
added
needs content update
ddbeck
requested changes
Jun 17, 2021
api/Document.json
Outdated
| @@ -6481,7 +6481,7 @@ | |||
| "deprecated": false | |||
| } | |||
| }, | |||
| "deep_optional": { | |||
| "deep_parameter_optional": { | |||
There was a problem hiding this comment.
I'm all but certain this is an irrelevant feature. My impression is that deep was required when it was first introduced, but isn't now. I guess it's possible that EdgeHTML required, but I doubt it, given how thin this data is anyway. I'd rather see this one go away entirely.
There was a problem hiding this comment.
I'll revert this change and send a separate PR. Since the Firefox versions are set this smells a lot like a "we changed something and should document it" entry that stops being useful very soon after the Firefox release.
ddbeck
removed
the
needs content update
ddbeck
added a commit
to ddbeck/browser-compat-data
that referenced
this pull request
Jun 18, 2021
ddbeck
added a commit
that referenced
this pull request
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#parameters-and-parameter-object-features