Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IDBTransaction.durability and add IDBChangeVersionEvent() #10993

Merged
merged 12 commits into from
Jun 18, 2021

Conversation

teoli2003
Copy link
Contributor

IDBTransaction.durability was missing spec_url and IDBChangeVersionEvent constructor was missing (I added it with Fx info that is from https://bugzilla.mozilla.org/show_bug.cgi?id=890382.

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jun 13, 2021
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the compat data for the IDBVersionChangeEvent() constructor is quite likely the same as the data we recorded for the interface?

@teoli2003
Copy link
Contributor Author

teoli2003 commented Jun 14, 2021

I thought this initially, but I looked for the bug for Firefox (my bugzilla skills are not too rusty, finally) and it was different… Hence the null values for the others.

Copy link
Collaborator

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinned down Chromium data, will suggest Safari separately.

api/IDBVersionChangeEvent.json Outdated Show resolved Hide resolved
api/IDBVersionChangeEvent.json Outdated Show resolved Hide resolved
api/IDBVersionChangeEvent.json Outdated Show resolved Hide resolved
api/IDBVersionChangeEvent.json Outdated Show resolved Hide resolved
api/IDBVersionChangeEvent.json Outdated Show resolved Hide resolved
api/IDBVersionChangeEvent.json Outdated Show resolved Hide resolved
api/IDBVersionChangeEvent.json Outdated Show resolved Hide resolved
api/IDBVersionChangeEvent.json Outdated Show resolved Hide resolved
api/IDBVersionChangeEvent.json Outdated Show resolved Hide resolved
api/IDBVersionChangeEvent.json Outdated Show resolved Hide resolved
teoli2003 and others added 10 commits June 18, 2021 13:52
Co-authored-by: Philip Jägenstedt <[email protected]>
Co-authored-by: Philip Jägenstedt <[email protected]>
Co-authored-by: Philip Jägenstedt <[email protected]>
Co-authored-by: Philip Jägenstedt <[email protected]>
Co-authored-by: Philip Jägenstedt <[email protected]>
Co-authored-by: Philip Jägenstedt <[email protected]>
Co-authored-by: Philip Jägenstedt <[email protected]>
Co-authored-by: Philip Jägenstedt <[email protected]>
Co-authored-by: Philip Jägenstedt <[email protected]>
Co-authored-by: Philip Jägenstedt <[email protected]>
@teoli2003
Copy link
Contributor Author

Thanks for the tip!

@teoli2003 teoli2003 requested a review from foolip June 18, 2021 11:54
@foolip foolip merged commit a8c9061 into mdn:main Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants