Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore index.js entry point #10033

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Restore index.js entry point #10033

merged 1 commit into from
Apr 22, 2021

Conversation

saschanaz
Copy link
Contributor

@saschanaz saschanaz commented Apr 22, 2021 •
edited
Loading

This is required for ES module compatibility since it does not support JSON import.

If we don't want to do this then a major version bump should happen since #7398 was a breaking change.

Closes #9966

A checklist to help your pull request get merged faster:

  • Summarize your changes
  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
  • Data: if you tested something, describe how you tested with details like browser and version
  • Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
  • Link to related issues or pull requests, if any

@saschanaz
Restore index.js entry point
3316745 
This is required for ES module compatibility since it does not support JSON import.
@github-actions github-actions bot added the scripts 📜 Issues or pull requests regarding the scripts in scripts/. label Apr 22, 2021
ddbeck
ddbeck approved these changes Apr 22, 2021
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed that this PR fixes the problem reported in #9966, under the steps to reproduce in #9966 (comment). Thanks for the report and fix, @saschanaz!

@ddbeck ddbeck merged commit c321920 into mdn:main Apr 22, 2021
@saschanaz saschanaz deleted the index-js branch April 22, 2021 17:25
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Apr 22, 2021
@ddbeck
Add release note for mdn#10033
05de10b
ddbeck added a commit that referenced this pull request Apr 22, 2021
@ddbeck
Prepare release v3.3.1 (#10014)
254cf71 
* Bump version to 3.3.1
* Add release note for #9626
* Add release note for #10033
* Add release note for #10000
* Add release stats
* Fix inconsistency in release notes stats
@ddbeck ddbeck mentioned this pull request Aug 24, 2021
Merged
@saschanaz saschanaz mentioned this pull request Aug 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddbeck ddbeck ddbeck approved these changes

Assignees
No one assigned
Labels
scripts 📜 Issues or pull requests regarding the scripts in scripts/.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot import BCD from ES module anymore in 3.3.0
3 participants
@saschanaz @ddbeck @queengooborg