Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency on Webview Android versions #3034

Closed
CKGrafico opened this issue Oct 29, 2018 · 2 comments
Closed

Inconsistency on Webview Android versions #3034

CKGrafico opened this issue Oct 29, 2018 · 2 comments
Labels
invalid Invalid issues or pull requests (wrong repo, spam, duplicates, etc.). This won't get merged. Sorry!

Comments

@CKGrafico
Copy link

CKGrafico commented Oct 29, 2018

We are working on this feature for webhint using your awesome package webhintio/rfcs#10

But we have found some inconsistency in the data (maybe we are not understanding well).

When we check the version of webview_android we receive different results:

If we check, at rule media we can see that is supported since version 1, https://github.com/mdn/browser-compat-data/blob/master/css/at-rules/media.json#L45 but the at rule viewport since version https://github.com/mdn/browser-compat-data/blob/master/css/at-rules/viewport.json#L92 but also other subproperty is for version 41 https://github.com/mdn/browser-compat-data/blob/master/css/at-rules/media.json#L201

We have to compare the supported browsers of our list with these versions but we are not sure if we can use 41 as 4.1 or if 41 is browser version a 4.4.3 is for OS version, etc.

https://developer.mozilla.org/en-US/docs/Web/CSS/@media
img

@Elchi3
Copy link
Member

Elchi3 commented Oct 29, 2018

Hey, thanks for working on integrating this dataset into webhint! :)

WebView versions are a bit tricky, because the browser was coupled with the Android OS version for a while (until Android 5), but then it was possible to update the browser as an app separately, so the latest Chromium version number is used. Caniuse does this the same way, see the tooltip when clicking on "Android Browser*", for example.

See also the discussion here #2690 (comment) and this file https://github.com/mdn/browser-compat-data/blob/master/browsers/webview_android.json with valid versions for webview android.

@CKGrafico
Copy link
Author

@Elchi3 that link is enough for us #2690 (comment) thanks for your help

@queengooborg queengooborg added invalid Invalid issues or pull requests (wrong repo, spam, duplicates, etc.). This won't get merged. Sorry! wontfix 👎 labels Jun 10, 2019
@queengooborg queengooborg closed this as not planned Won't fix, can't repro, duplicate, stale Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid Invalid issues or pull requests (wrong repo, spam, duplicates, etc.). This won't get merged. Sorry!
Projects
None yet
Development

No branches or pull requests

3 participants