-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "yes" as an option #3021
Comments
Yes, this is highly misleading! I wasn't certain what it meant. Where on MDN is that explained? I noticed this on the Node.textContent property (IE is marked as "yes") and seem to recall having seen it elsewhere. I'm willing to spend some time helping out with this issue (for desktop browsers, since I have many versions of them to test in and relatively fewer for mobile). Has anyone written a script (preferably in JS or PHP) to process these JSON files to look for data from specific browsers (which in my case would be Windows and MacOSX browsers)? |
So something like this?: {
"version_added": true,
"first_observed": 44
} |
Yeah I've been wondering this for quite a while actually, and only thought to look into reporting this request today. I agree that "Yes" is vague & confusing, and can't think of any benefits over just showing the version number? Which it already does... but only sometimes? It's been especially obvious to me lately as I've just started programming in Node this year... and I don't think it ever shows the version number for the Node column? And for features that have always been supported by the software in all versions, instead of "Yes" it would be much clearer to instead write "All". There looks like some similar github issues on here talking about this stuff, so maybe it's already under way? |
IMO the best way to fix this is get the exact number for all Yes things, via something like MDN-athon 😄 |
First observed is an interesting idea though I wonder if it’d be worth the trouble, A simple fix right now would be to add alt text on the “Yes” to explain what it means. |
I’m in favour of adding alt text. |
Alt text is fine for a stopgap; obviously the endgame is to eliminate "yes" and have actual version numbers for everything. |
We can do some batch conversion for some cases: if IE is marked as supported and Edge is marked as |
For the record, 'all' would be incredibly misleading for Chrome data currently 'yes'. In fact, it's so far off the mark that I (not to mention my company's legal department) would consider it deceptive. |
'First observed' might be a problem too. I can imagine someone writing, for example, |
|
Or support the |
|
It would be in |
@Elchi3 is this the right issue for deciding on whether to allow |
I’ll open up the PR for allowing that syntax. It will also require a companion PR in mdn/kumascript which will depend on mdn/kumascript#1010 |
We haven't decided this yet, I think. I guess the assumption here is that it is better to have a syntax like "<=60" rendered to MDN Web Docs readers and other compat data consumers than it would be to have "Yes"/true delivered to them. I would be interested in finding out if this assumption is true and also if other data consumers would be OK with working with data like "<=60" (most importantly VSCode and webhintio) |
|
I'd prefer the latter. Tables are tight as it is.
Joe Medley | Technical Writer, Chrome DevRel | [email protected] |
816-678-7195
*If an API's not documented it doesn't exist.*
…On Wed, Feb 20, 2019 at 10:56 AM ExE Boss ***@***.***> wrote:
<=60 would be rendered as “Added “ in 60 or earlier”, or just
“60 or earlier”
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3021 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AH0viyoVccnV1Wn-MDoy7yG_Mp6BycxJks5vPZp1gaJpZM4X3yeE>
.
|
I like the simplicity of Support was first observed in [BROWSER] [VERSION], but may be supported in earlier versions. Please consider contributing to the BCD repo if you know the exact browser version this was implemented in. |
I’m gonna work on adding support for this. (will require #3739 to be merged and changes to the KumaScript |
Thanks @ExE-Boss. We will have to discuss this and then make a call if we want to go down this route. I appreciate some patience. |
Philip and I both support something like '<=60'. It's not perfect, but it moves us closer to the goal of having numbers or false everywhere. |
@antross can you provide input for webhint.io? Is this something you could work with? |
My own impression of the situation is that for at least some features we won't be able to tell when they were introduced without a lot of effort and it's of limited value to address whether something was implemented in Safari 1 or Safari 2 for example. That makes it somewhat difficult to say where the line is, but that's probably still better than providing no information, because we don't know for sure. |
@octref can you provide input for VS Code? |
So basically, to be clear, if you know that a feature exists in Firefox 55 but don't know when it was added, you can do |
Can someone @mention me whenever this change is merged? It'll probably break the data parsing setup I have for my BCD Explorer, so I'll need to put in some work once that happens. |
@atopal I have no problem with whichever decision you arrive at, just that |
For what it's worth, I view this as a useful step in the direction of getting version numbers for everything. If I have a thousand 'yes' values where do I start? But say a feature landed in 26. Which is more useful, <=28 or <=60? There's the clue as to how I prioritize. I start with everything that's <=currentVersion and work backwards. |
@atopal Yes, this is something webhint can work with. Given we focus on lack of support to trigger warnings we probably won't change our logic compared to |
If you know that it exists in Firefox 55, but aren’t sure when it was added (eg. it’s an old‑ish feature), you’d do: |
Another way to look at it is that Seeing BCD as a huge browser+version × supported table, it makes it possible to have a row with mixed null+true, where previously only false+true was possible.
If supported, that means "not available in 60 or later" but doesn't imply anything about the versions between |
The use of "Yes" instead of the actual version I tested a feature in has been bothering me many years before the BCD project was born. It was also misleading, because it doesn't account for the cases in which a feature was removed and readded at some point. So I am happy this issue gets addressed now. While it is an obvious fit to reuse So, if we decide on this syntax change, all project owners should get informed about it and given some time to adjust their implementations to account for that before the change happens. Sebastian |
FWIW I’m fine with breaking changes, I don’t want my project to hold back progress of the BCD project :) I would of course appreciate forewarning, but I follow the repo enough that I usually find out on my own. |
At first, I was skeptical about this, and I was wondering whether this provided any real use. I was thinking that it would just be easier to try to find a better way to describe Bottom line, I'm in full support of this feature. Can't wait for it to be added! * Seems like SauceLabs has Edge 13 and 14, by the way. |
FWIW, I have Edge 12 in a VM, so given automated tests I can get results on request. |
Glad to hear, @foolip! Since I’ve only got IE (the full collection) and Edge 15-18, I’ll most likely reach out to to you for assistance on some of the IE/Edge testing. 😉 |
Alright, so update on this: In #4330, we decided to add support for version ranges, however only certain browsers may use these (specifically, WebView ≤37). Since it's so challenging to test such old versions of those browsers (and not to mention because of their age, they're not used at all), we're allowing specific browsers to indicate support may have been introduced in the older versions. Overall, BCD's 2019 goal was to increase the quality of the compatibility data, which meant replacing I feel that it's best to close this issue to do a little repository cleanup, and since we're already working to disallow |
We talked about this a while ago, but I didn't see it in the list of issues, so I thought I'd write it down.
In a previous round of user interviews, we asked people to explain the compat data table on MDN to us. When we asked about the use of "yes" in cells, almost no one had a correct understanding of that attribute. Some people thought yes meant that all versions of the browser support that feature, some thought that it means you don't have to worry about support. Nobody knew what it actually stands for: It's supported in the version that the person who added that attribute tested.
This is bad for 2 reasons:
My suggestion is to replace it either with the exact version or with something that says "at least since version x". While "at least since version x" might not be very useful today, if it's the current version of the browser, it will be all that people care about 3 years from now.
The text was updated successfully, but these errors were encountered: