Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): replace margin-top on tab-list by border-top on tab #773

Merged
merged 1 commit into from
May 2, 2022

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Apr 29, 2022

Fixes #725.

Screenshots

Before

image

After

image

@schalkneethling
Copy link

### After

I notice that in the screenshot the editor now shows a vertical scrollbar. I guess that was not the intent?

@caugner
Copy link
Contributor Author

caugner commented May 2, 2022

@schalkneethling I'm pretty sure that scrollbar is a random artefact that is unrelated to my changes. I haven't actually tested this locally (because I haven't figured this out yet), but instead applied the changes manually to an MDN page with interactive examples.

@schalkneethling schalkneethling merged commit d34d8a0 into main May 2, 2022
@schalkneethling schalkneethling deleted the remove-editor-tab-margin-top branch May 2, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WASM example layout is incorrect
2 participants