Remove %example-css-src% when no path to CSS (#988)

* Remove "%example-css-src%" when no path to CSS * Change to ternary * Change to ternary in addCSS
mdn · Nov 24, 2022 · 4abcd2a · 4abcd2a
1 parent 2bb4423
commit 4abcd2a
Showing 1 changed file with 12 additions and 18 deletions.
diff --git a/lib/tabbedPageBuilder.js b/lib/tabbedPageBuilder.js
@@ -9,16 +9,12 @@ import * as processor from "./processor.js";
  * @returns the processed template string
  */
 function addCSS(currentPage, tmpl) {
-  if (currentPage.cssExampleSrc) {
-    tmpl = tmpl.replace(
-      "%example-css-src%",
-      fse.readFileSync(currentPage.cssExampleSrc, "utf8")
-    );
-  } else {
-    tmpl.replace("%example-css-src%", "");
-  }
-
-  return tmpl;
+  return tmpl.replace(
+    "%example-css-src%",
+    currentPage.cssExampleSrc
+      ? fse.readFileSync(currentPage.cssExampleSrc, "utf8")
+      : ""
+  );
 }
 
 /**
@@ -40,14 +36,12 @@ function addHTML(currentPage, tmpl) {
  * @returns the processed template string
  */
 function addJS(currentPage, tmpl) {
-  if (currentPage.jsExampleSrc) {
-    tmpl = tmpl.replace(
-      "%example-js-src%",
-      fse.readFileSync(currentPage.jsExampleSrc, "utf8")
-    );
-  } else {
-    tmpl = tmpl.replace("%example-js-src%", "");
-  }
+  tmpl = tmpl.replace(
+    "%example-js-src%",
+    currentPage.jsExampleSrc
+      ? fse.readFileSync(currentPage.jsExampleSrc, "utf8")
+      : ""
+  );
 
   return tmpl;
 }