Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: -Category parameter should be case insensitive #9

Merged
merged 5 commits into from
Feb 29, 2024

Conversation

AndrewPla
Copy link

Changed the command to use the -Contains operator rather than using .contains.

@mdgrs-mei
Copy link
Owner

Thank you! There are a few more places where I used Contains method for the category inside the EnableEntries functions. Could you modify them too?

e.g. in FileSystemRegistry

@AndrewPla
Copy link
Author

I ran this to identify all of the files that use .contains

Get-ChildItem -Path .\ -Filter *.ps1 -Recurse | ForEach-Object {
    if (Select-String -Path $_.FullName -Pattern '\.contains' -Quiet) {
        code $_.FullName
    }
}

Now there is just one instance of .Contains, which is used in ApplicationRegistry.ps1 on. line 75, but it is fine here.
if (-not $item.Path.Contains('!')) {

@mdgrs-mei
Copy link
Owner

I see some formatting changes which reminds me that we should force the formatting. I will unify them later.

Thank you for the fix. Looks good on the feature wise.

@mdgrs-mei mdgrs-mei merged commit 58d1cc5 into mdgrs-mei:main Feb 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants