Mark group permission unusable for pulpcore 3.20

fixes pulp#501 (cherry picked from commit 7f5c638)
mdellweg · Jul 15, 2022 · b1749c1 · b1749c1
1 parent f13bed3
commit b1749c1
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/CHANGES/501.removal b/CHANGES/501.removal
@@ -0,0 +1 @@
+Marked `group permission` command unusable with pulpcore 3.20.
diff --git a/pulpcore/cli/core/group.py b/pulpcore/cli/core/group.py
@@ -16,6 +16,7 @@
     lookup_callback,
     name_option,
     null_callback,
+    pulp_group,
     role_command,
     show_command,
 )
@@ -52,7 +53,7 @@ def _object_callback(ctx: click.Context, param: click.Parameter, value: str) ->
 )
 
 
-@click.group(help=_("Manage user groups and their granted permissions."))
+@pulp_group(help=_("Manage user groups."))
 @pass_pulp_context
 @click.pass_context
 def group(ctx: click.Context, pulp_ctx: PulpContext) -> None:
@@ -71,7 +72,7 @@ def group(ctx: click.Context, pulp_ctx: PulpContext) -> None:
 )
 
 
-@group.group()
+@group.group(needs_plugins=[PluginRequirement("core", max="3.20-dev")])
 @click.option(
     "-t",
     "--type",

diff --git a/tests/scripts/pulpcore/test_group_permissions.sh b/tests/scripts/pulpcore/test_group_permissions.sh
@@ -3,7 +3,7 @@
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 
-pulp debug has-plugin --name "core" || exit 3
+pulp debug has-plugin --name "core" --max-version "3.20-dev" || exit 3
 
 cleanup() {
   pulp group destroy --name "cli_test_group" || true
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Marked `group permission` command unusable with pulpcore 3.20.