Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wait_until_ready config and check if phiremock server is actually running #48

Merged
merged 4 commits into from
May 1, 2021

Conversation

barell
Copy link
Contributor

@barell barell commented Apr 9, 2021

This PR adds:

  • new configs: wait_until_ready and wait_until_ready_timeout
  • if wait_until_ready is set to true it will use phiremock client reset method to call phiremock server
  • if phiremock server does not respond within specified timeout, exception will be thrown
  • some updates to README

@barell
Copy link
Contributor Author

barell commented Apr 9, 2021

This is to fix issue: #47

@barell
Copy link
Contributor Author

barell commented Apr 16, 2021

Made some further improvements to this PR. It can now use Phiremock Client and fallback to curl request. If both Phiremock client and curl extension are not present and wait_until_ready is set to true it will throw exception.

@mcustiel mcustiel merged commit 7425ba9 into mcustiel:master May 1, 2021
@mcustiel
Copy link
Owner

mcustiel commented May 1, 2021

@barell thank you very much for your support to phiremock and sorry for the delay to review/merge your PR.

@barell
Copy link
Contributor Author

barell commented May 1, 2021

Awesome, thanks @mcustiel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants