Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setScenarioState to module #38

Merged

Conversation

mikhailsamarkin
Copy link

Added the ability to install scenario state

src/Module/Phiremock.php Outdated Show resolved Hide resolved
@mcustiel
Copy link
Owner

mcustiel commented Oct 7, 2020

Thank you for this PR @mikhailsamarkin I never noticed that was missing. Please check my comment in the PR, besides that everything looks great.

@mcustiel
Copy link
Owner

mcustiel commented Oct 7, 2020

I already added the same feature in master of phiremock-codeception-module.

@mikhailsamarkin
Copy link
Author

I already added the same feature in master of phiremock-codeception-module.

From master was removed expectARequestToRemoteServiceWithAResponse and another methods ;(

@mcustiel mcustiel merged commit 20ed813 into mcustiel:version-1.x Oct 8, 2020
@mcustiel
Copy link
Owner

mcustiel commented Oct 8, 2020

I already added the same feature in master of phiremock-codeception-module.

From master was removed expectARequestToRemoteServiceWithAResponse and another methods ;(

Yes, in version 2 the module and the extension are 2 separated repositories. I added your change to master in the module: https://github.com/mcustiel/phiremock-codeception-module

Copy link
Owner

@mcustiel mcustiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants