Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boot: Allow watchdog timeout to be configured #2131

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

KarlKTorp
Copy link
Contributor

This change adds a new Kconfig option MCUBOOT_WATCHDOG_TIMEOUT to specify the watchdog timeout value. Several devices (NXP among others) require a timeout to be installed in order to enable the watchdog. On e.g. imxrt1170 enabling the watchdog without a timeout will print the error "No valid timeouts installed" and fail to setup the watchdog.

Fixes: #2093

This change adds a new Kconfig option MCUBOOT_WATCHDOG_TIMEOUT to
specify the watchdog timeout value. Several devices (NXP among others)
require a timeout to be installed in order to enable the watchdog.

Signed-off-by: Karl Kristian Dyrholm Torp <[email protected]>
Copy link
Collaborator

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The watchdog code in mcuboot is a bit of a red herring, it does not set up a watchdog, it only feeds it. And it does not make sense to set the watchdog up every time it is fed

Signed-off-by: Karl Kristian Dyrholm Torp <[email protected]>
@KarlKTorp
Copy link
Contributor Author

Right. That was my bad. It was of cause during setup the timeout should be installed - good catch.

This is just a suggestion for the watchdog issues on NXP, we have used this method for some time. But I can see that watchdog support is limited in mcuboot and this might not be the optimal solution. That's up to you guys :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect initialisation of hardware watchdog
2 participants