boot: Refactoring image dependency functions to reduce code size #1911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-nordic
force-pushed
the
dependency_code_refactoring
branch
3 times, most recently
from
afc894e to
a414922
Compare
nvlsianpu
reviewed
Mar 7, 2024
There have been duplicate functions: boot_verify_dependencies boot_verify_slot_dependencies boot_verify_slot_dependency with, very similar internals, scattered around unit. The commit have moved them on top and squashed where possible. Signed-off-by: Dominik Ermel <[email protected]>
de-nordic
force-pushed
the
dependency_code_refactoring
branch
from
34f2a3e to
bbe3fcd
Compare
nvlsianpu
approved these changes
Mar 7, 2024
|
@d3zd3z I would merge this - Code is almost the same as it was (no algorithm changes), just cleaned-up a little. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been duplicate functions:
boot_verify_dependencies
boot_verify_slot_dependencies
boot_verify_slot_dependency
with, very similar internals, scattered around unit. The commit have moved them on top and squashed where possible.