Skip to content

Commit

Permalink
For mozilla-mobile#5102 - post: update comment to avoid suggesting we…
Browse files Browse the repository at this point in the history
…'ll remove this later.
  • Loading branch information
mcomella committed Aug 13, 2021
1 parent 4f59fc9 commit 8450e49
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions app/proguard-rules.pro
Original file line number Diff line number Diff line change
Expand Up @@ -144,10 +144,9 @@
# as bundled with AGP v7.0.0 causes this optimization to fail so we use the fast service loader instead. See:
# https://github.com/mozilla-mobile/focus-android/issues/5102#issuecomment-897854121
#
# The fast service loader appears to be as performant as the R8 optimization, however, this proguard
# implementation is more fragile because it relies upon the coroutines source not changing. We
# should back this out when the R8 bug is solved. We are tracking this in:
# https://github.com/mozilla-mobile/focus-android/issues/5121
# The fast service loader appears to be as performant as the R8 optimization so it's not worth the
# churn to later remove this workaround. If needed, the upstream fix is being handled in
# https://issuetracker.google.com/issues/196302685
####################################################################################################
-assumenosideeffects class kotlinx.coroutines.internal.MainDispatcherLoader {
boolean FAST_SERVICE_LOADER_ENABLED return true;
Expand Down

0 comments on commit 8450e49

Please sign in to comment.