Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undefined cb in emit fix #21 #22

Merged
merged 2 commits into from
Feb 27, 2020
Merged

undefined cb in emit fix #21 #22

merged 2 commits into from
Feb 27, 2020

Conversation

robertsLando
Copy link
Contributor

No description provided.

@mcollina
Copy link
Owner

This needs a test.

@robertsLando robertsLando mentioned this pull request Feb 27, 2020
Closed
@robertsLando
Copy link
Contributor Author

@mcollina Please make a patch release for this

mcollina
mcollina approved these changes Feb 27, 2020
View reviewed changes
Copy link
Owner

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 9040c9d into mcollina:master Feb 27, 2020
@robertsLando robertsLando deleted the patch-1 branch February 28, 2020 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertsLando @mcollina