Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue with emitted error event names (#15) #17

Closed
wants to merge 1 commit into from
Closed

Fixes issue with emitted error event names (#15) #17

wants to merge 1 commit into from

Conversation

leobudima
Copy link

@leobudima leobudima commented Jan 15, 2020 •
edited
Loading

Fixes #15

mcollina
mcollina requested changes Jan 15, 2020
View reviewed changes
Copy link
Owner

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing, would you mind to fix it?

Also, would you mind to add a unit test?

@robertsLando robertsLando mentioned this pull request Feb 27, 2020
Merged
@mcollina
Copy link
Owner

Closing for no activity, feel free to reopen if needed.

@mcollina mcollina closed this Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emitting the 'error' throws an unhandled error
2 participants
@leobudima @mcollina