Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidy up shipped package #16

Merged
merged 2 commits into from
May 7, 2020
Merged

tidy up shipped package #16

merged 2 commits into from
May 7, 2020

Conversation

osher
Copy link
Contributor

@osher osher commented Apr 26, 2020

shipped tidy up:

{17:45}~/opensource/hyperid:master ✓ ➭ git checkout patch-2
Switched to branch 'patch-2'
Your branch is up to date with 'origin/patch-2'.
{17:45}~/opensource/hyperid:patch-2 ✓ ➭ npm pack
npm notice 
npm notice 📦  [email protected]
npm notice === Tarball Contents === 
npm notice 1.1kB LICENSE     
npm notice 2.1kB hyperid.js  
npm notice 1.1kB package.json
npm notice 2.1kB README.md   
npm notice 456B  index.d.ts  
npm notice === Tarball Details === 
...
npm notice package size:  3.0 kB                                  
npm notice unpacked size: 6.8 kB   

vs, shipped unfiltered

{17:42}~/opensource/hyperid:patch-2 ✓ ➭ git checkout master
Switched to branch 'master'
Your branch is up to date with 'origin/master'.
{17:43}~/opensource/hyperid:master ✓ ➭ npm pack
npm notice 
npm notice 📦  [email protected]
npm notice === Tarball Contents === 
npm notice 1.1kB LICENSE           
npm notice 913B  benchmark.js      
npm notice 206B  example.js        
npm notice 2.1kB hyperid.js        
npm notice 1.9kB test/test.js      
npm notice 1.4kB test/uniqueness.js
npm notice 1.0kB package.json      
npm notice 154B  test/tsconfig.json
npm notice 2.1kB README.md         
npm notice 330B  test/example.ts   
npm notice 456B  index.d.ts        
npm notice 79B   .travis.yml       
npm notice === Tarball Details === 
...
npm notice package size:  4.2 kB                                  
npm notice unpacked size: 11.8 kB 

package.json Show resolved Hide resolved
@mcollina
Copy link
Owner

mcollina commented May 6, 2020

This adds a spurious tar.gz file.Can you remove that?

@osher
Copy link
Contributor Author

osher commented May 7, 2020

OMG. shame on me.
well, this tar is the result of npm pack - which is how I check what will end up shipping.
In more complicated scenarios I even check how well it installs, and if it creates the bins well, but now I just wanted to look at the shipped archive.

My bad - I missed it's being included in the git add. pitty...

Copy link
Owner

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 8153322 into mcollina:master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants