-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci!: update workflow #454
ci!: update workflow #454
Conversation
@Fdawgs apparently this fails on CI on Node v18. Could you take a look? |
Not 100% on this one. Seems to be an issue with passing I've looked through the V17 and V18 changelogs and can't spot any breaking changes in this area. 😢 |
Maybe skips? |
Found the issue: nodejs/node#40672 Have recreated the test pkcs12 file using OpenSSL v3 and it now uses a supported cipher. |
Don't know if it's worth adding |
add them! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
CI is failing :( |
There we go! |
thx |
BREAKING CHANGE: Drops support for EOL node 12 and 15; adds support for node 18
This PR:
persist-credentials: false
, they are not used after the initial checkoutconcurrency
; see related docs, this allows a subsequently queued workflow run to interrupt previous runs in PRsif
to the automerge job; this stops the job from running if the user is not Dependabot, saving a few seconds CI run timecloses #427
closes #431
closes #456