fix: parse argument with ":" in value header #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BridgeAR
approved these changes
Jan 1, 2020
As documented header parsing should support arguments like `-H "Date=Wed Jan 01 2020 20:02:36 GMT+0800 (Hong Kong Time)"`.
legendecas
force-pushed
the
header-parsing
branch
from
cad849a
to
5a3de5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As documented header parsing should support arguments like
-H "Date=Wed Jan 01 2020 20:02:36 GMT+0800 (Hong Kong Time)".Currently the header would be sent as
Date=Wed Jan 01 2020 20: 02:36 GMT+0800 (Hong Kong Time).Fixes: nodejs/node#31023