Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHINO.INSIDE.REVIT RhinoCode Platform - DO NOT MERGE #1199

Draft
wants to merge 5 commits into
base: 1.x
Choose a base branch
from

Conversation

eirannejad
Copy link
Contributor

@eirannejad eirannejad commented Oct 11, 2024

Starting this PR as a thread to review and improve this first draft of RHINO.INSIDE.REVIT platform for Rhino3d scripting.

Todo

  • @kike-garbo Needs change to set minimum Rhino to 8.15
  • @kike-garbo Needs to call Rhino.Runtime.Code.RhinoCode.Platforms.TryRegister(Scripting.RhinoInsideRevitPlatform.Instance); sooner when Rhino is started. Currently this call is made in AssemblyPriority of the GH plugin. So platform is not ready if ScriptEditor is launched without Grasshopper being loaded (I assume this is a rare case :D)
  • @eirannejad Needs more converters (this also needs cleanups if GH definitions containing these converter/hints are being published as plugins)
  • @eirannejad Needs url resolver for help libraries

Platform Assemblies

Adds RevitAPI, RevitAPIUI and AdWindows to all scripting languages. Opening the file below should not throw any errors.

test_rir_compile.zip

Revit_AAWjcMUwgc

Platform assemblies are also automatically added to autocompletion:

Revit_OgmNpr8wKc

Platform Value Converters

Adds one single ElementId converter under Revit. Opening the file below should not throw any errors:

test_rir_converters_element.zip

Revit_to3HJ7omNI

Platform Compile Guards

Adds 'flexible' guards for major versions starting from Revit 2018
Example: REVIT_2018_OR_GREATER, REVIT_2019_OR_GREATER

Adds 'specific' guards that are only available on this Revit version
Example: REVIT_2025_1, REVIT_2025

Platform Help Libraries

Adds RevitAPI and RevitAPIUI to editor help libraries:

Revit_PaJ2uxU6jm

- only works when gh is loaded
- only has one converter
- provided revit api in editor help but needs uri resolver
- does not implement active document, write, or find assembly methods
@eirannejad eirannejad changed the title RHINO.INSIDE.REVIT RhinoCode Platform RHINO.INSIDE.REVIT RhinoCode Platform - DO NOT MERGE Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant