Various fixes #123
Open
Various fixes #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's touched from interrupt handler, it seems to me like it should be volatile
ORing with 0 won't do anything; I can only imagine the original intent of this code was to OR with ~0.
It seems that Windows really wants these implemented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are various fixes I've accumulated. The first SPI fix prevents the compiler from performing potentially dangerous optimizations. The second correctly clears the
SRregister. The next implements control requests required by Windows 7 (and possibly later, maybe earlier). The last is a style fix.