forked from apache/gravitino
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[apache#1546] fix(lakehouse-iceberg): fix create Iceberg table failed…
… if comment is null (apache#1653) ### What changes were proposed in this pull request? remove reserveProperties logic from CreateTableRequest since reserved properties is handled by property system ### Why are the changes needed? 1. when build IcebergTable, comment equals to null is checked when comment added to properties . ``` if (null != comment) { icebergTable.properties.putIfAbsent(ICEBERG_COMMENT_FIELD_NAME, comment); } ``` 2. when build CreateTableRequest, the previous implement remove all reserved properties from property map including comment, and then add comment to map, the bug happens, not checking the null, but this overall code is redundant Fix: apache#1546 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? add UT
- Loading branch information
Showing
3 changed files
with
16 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters