Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for cython 3 #10

Merged
merged 4 commits into from
Sep 18, 2023
Merged

Update for cython 3 #10

merged 4 commits into from
Sep 18, 2023

Conversation

mcflugen
Copy link
Owner

This is a small pull request that updates the cython code to work with cython 3. All that was done was to add noexcept to a couple of the functions. This fixes two compile errors.

plume/ext/centerline.pyx:140:17: Cannot assign type 'double (*)(double, void *) except? -1 nogil' to 'double (*)(double, void *) noexcept nogil'. Exception values are incompatible. Suggest adding 'noexcept' to type 'double (double, void *) except? -1 nogil'.

@mcflugen
Copy link
Owner Author

I also had to set PYTHONIOENCODING="utf-8" for the CI to avoid a unicode encoding error on Windows. This error is likely the result of the LANG environment variable not being set (see Textualize/rich#212).

@mcflugen mcflugen merged commit b2aa0b0 into develop Sep 18, 2023
16 checks passed
@mcflugen mcflugen deleted the mcflugen/update-for-cython-3 branch September 18, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant