Fixes scapegoat-scala#340. Excusing arguments annotated with @unused

mccartney · Oct 14, 2020 · 5851f13 · 5851f13
1 parent 4a61bc3
commit 5851f13
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/main/scala/com/sksamuel/scapegoat/inspections/unneccesary/UnusedMethodParameter.scala b/src/main/scala/com/sksamuel/scapegoat/inspections/unneccesary/UnusedMethodParameter.scala
@@ -43,6 +43,9 @@ class UnusedMethodParameter
             }
           }
 
+          private def isParameterExcused(param: ValDef): Boolean =
+            param.symbol.annotations.exists(_.atp.toString == "scala.annotation.unused")
+
           /**
            * For constructor params, some params become vals / fields of the class:
            *   1. all params in the first argument list for case classes
@@ -109,8 +112,9 @@ class UnusedMethodParameter
                 for {
                   vparams <- vparamss
                   vparam  <- vparams
-                } if (!usesParameter(vparam.name.toString, rhs))
+                } if (!isParameterExcused(vparam) && !usesParameter(vparam.name.toString, rhs)) {
                   context.warn(tree.pos, self, s"Unused method parameter ($vparam).")
+                }
               case _ => continue(tree)
             }
           }