fix: Upgrade lambda runtime to node 14.x (philips-labs#1203)

* Bump node from 12.x to 14.x for lambdas Co-authored-by: Niek Palm <[email protected]> * set node version in .nvmrc to 14 * upgrade terraform version as required by module Co-authored-by: Niek Palm <[email protected]> Co-authored-by: Niek Palm <[email protected]>
mcaulifn · Oct 7, 2021 · 570949a · 570949a
1 parent e2a4037
commit 570949a
Show file tree

Hide file tree

Showing 18 changed files with 55 additions and 30 deletions.
diff --git a/.ci/Dockerfile b/.ci/Dockerfile
@@ -1,5 +1,5 @@
 #syntax=docker/dockerfile:1.2
-FROM node:12 as build
+FROM node:14 as build
 WORKDIR /lambda
 RUN apt-get update \
         && apt-get install -y zip \

diff --git a/.github/workflows/lambda-runner-binaries-syncer.yml b/.github/workflows/lambda-runner-binaries-syncer.yml
@@ -14,7 +14,7 @@ on:
 jobs:
   build:
     runs-on: ubuntu-latest
-    container: node:12
+    container: node:14
     defaults:
       run:
         working-directory: ${{ env.lambda_path }}

diff --git a/.github/workflows/lambda-runners.yml b/.github/workflows/lambda-runners.yml
@@ -11,7 +11,7 @@ on:
 jobs:
   build:
     runs-on: ubuntu-latest
-    container: node:12
+    container: node:14
     defaults:
       run:
         working-directory: modules/runners/lambdas/runners

diff --git a/.github/workflows/lambda-webhook.yml b/.github/workflows/lambda-webhook.yml
@@ -11,7 +11,7 @@ on:
 jobs:
   build:
     runs-on: ubuntu-latest
-    container: node:12
+    container: node:14
     defaults:
       run:
         working-directory: modules/webhook/lambdas/webhook

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -10,9 +10,9 @@ jobs:
   prepare:
     name: Create dist
     runs-on: ubuntu-latest
-    container: node:12
+    container: node:14
     strategy:
-      matrix: 
+      matrix:
         lambda: ["modules/webhook/lambdas/webhook", "modules/runner-binaries-syncer/lambdas/runner-binaries-syncer", "modules/runners/lambdas/runners"]
     steps:
       - name: Extract lambda name
@@ -64,14 +64,14 @@ jobs:
           appInstallationValue: ${{ github.repository }}
 
       - name: Dry run release
-        if: github.event_name != 'pull_request' 
+        if: github.event_name != 'pull_request'
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Read only token
         run: |
           cp .release/* .
           yarn
           yarn release -d --repositoryUrl https://x-access-token:[email protected]/$GITHUB_REPOSITORY.git
-          
+
       - name: Release
         if: github.event_name != 'pull_request' && contains('refs/heads/master', github.ref)
         env:

diff --git a/examples/default/.terraform.lock.hcl b/examples/default/.terraform.lock.hcl
diff --git a/examples/default/versions.tf b/examples/default/versions.tf
@@ -2,7 +2,7 @@ terraform {
   required_providers {
     aws = {
       source  = "hashicorp/aws"
-      version = ">= 3.20"
+      version = ">= 3.27"
     }
     local = {
       source = "hashicorp/local"

diff --git a/examples/permissions-boundary/providers.tf b/examples/permissions-boundary/providers.tf
@@ -1,7 +1,7 @@
 provider "aws" {
   alias   = "terraform_role"
   region  = local.aws_region
-  version = "3.20"
+  version = "3.60"
   assume_role {
     role_arn = data.terraform_remote_state.iam.outputs.role
   }

diff --git a/examples/ubuntu/providers.tf b/examples/ubuntu/providers.tf
@@ -1,7 +1,7 @@
 terraform {
   required_providers {
     aws = {
-      version = "3.20"
+      version = "3.27"
     }
     random = {
       version = "3.1.0"

diff --git a/modules/runner-binaries-syncer/lambdas/runner-binaries-syncer/.nvmrc b/modules/runner-binaries-syncer/lambdas/runner-binaries-syncer/.nvmrc
@@ -1 +1 @@
-v12.16.1
+v14
diff --git a/modules/runner-binaries-syncer/runner-binaries-syncer.tf b/modules/runner-binaries-syncer/runner-binaries-syncer.tf
@@ -12,7 +12,7 @@ resource "aws_lambda_function" "syncer" {
   function_name     = "${var.environment}-syncer"
   role              = aws_iam_role.syncer_lambda.arn
   handler           = "index.handler"
-  runtime           = "nodejs12.x"
+  runtime           = "nodejs14.x"
   timeout           = var.lambda_timeout
   memory_size       = 256
 

diff --git a/modules/runner-binaries-syncer/versions.tf b/modules/runner-binaries-syncer/versions.tf
@@ -0,0 +1,8 @@
+terraform {
+  required_providers {
+    aws = {
+      source  = "aws"
+      version = ">=3.27"
+    }
+  }
+}
diff --git a/modules/runners/scale-down.tf b/modules/runners/scale-down.tf
@@ -7,7 +7,7 @@ resource "aws_lambda_function" "scale_down" {
   function_name     = "${var.environment}-scale-down"
   role              = aws_iam_role.scale_down.arn
   handler           = "index.scaleDown"
-  runtime           = "nodejs12.x"
+  runtime           = "nodejs14.x"
   timeout           = var.lambda_timeout_scale_down
   tags              = local.tags
 

diff --git a/modules/runners/scale-up.tf b/modules/runners/scale-up.tf
@@ -7,7 +7,7 @@ resource "aws_lambda_function" "scale_up" {
   function_name                  = "${var.environment}-scale-up"
   role                           = aws_iam_role.scale_up.arn
   handler                        = "index.scaleUp"
-  runtime                        = "nodejs12.x"
+  runtime                        = "nodejs14.x"
   timeout                        = var.lambda_timeout_scale_up
   reserved_concurrent_executions = 1
   tags                           = local.tags

diff --git a/modules/runners/versions.tf b/modules/runners/versions.tf
@@ -0,0 +1,8 @@
+terraform {
+  required_providers {
+    aws = {
+      source  = "aws"
+      version = ">=3.27"
+    }
+  }
+}
diff --git a/modules/webhook/lambdas/webhook/.nvmrc b/modules/webhook/lambdas/webhook/.nvmrc
@@ -1 +1 @@
-v12.16.1
+v14
diff --git a/modules/webhook/versions.tf b/modules/webhook/versions.tf
@@ -0,0 +1,8 @@
+terraform {
+  required_providers {
+    aws = {
+      source  = "aws"
+      version = ">=3.27"
+    }
+  }
+}
diff --git a/modules/webhook/webhook.tf b/modules/webhook/webhook.tf
@@ -7,7 +7,7 @@ resource "aws_lambda_function" "webhook" {
   function_name     = "${var.environment}-webhook"
   role              = aws_iam_role.webhook_lambda.arn
   handler           = "index.githubWebhook"
-  runtime           = "nodejs12.x"
+  runtime           = "nodejs14.x"
   timeout           = var.lambda_timeout
 
   environment {