Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow LazyArrays 1 #73

Merged
merged 1 commit into from
Apr 22, 2024
Merged

allow LazyArrays 1 #73

merged 1 commit into from
Apr 22, 2024

Conversation

KristofferC
Copy link
Contributor

Without this, the package gets an old version of ArrayLayouts which errors on testing 1.11:

Failed to precompile LazyArrays [5078a376-72f3-5289-bfd5-ec5146d43c02] to "/home/pkgeval/.julia/compiled/v1.11/LazyArrays/jl_XdUB8l".
ERROR: LoadError: too many parameters for type AbstractTriangular
Stacktrace:
 [1] top-level scope
   @ ~/.julia/packages/ArrayLayouts/4IG3b/src/memorylayout.jl:712
 [2] include(mod::Module, _path::String)
   @ Base ./Base.jl:558
 [3] include(x::String)
   @ ArrayLayouts ~/.julia/packages/ArrayLayouts/4IG3b/src/ArrayLayouts.jl:1
 [4] top-level scope
   @ ~/.julia/packages/ArrayLayouts/4IG3b/src/ArrayLayouts.jl:103
 [5] include
   @ ./Base.jl:558 [inlined]
 [6] include_package_for_output(pkg::Base.PkgId, input::String, depot_path::Vector{String}, dl_load_path::Vector{String}, load_path::Vector{String}, concrete_deps::Vector{Pair{Base.PkgId, UInt128}}, source::String)
   @ Base ./loading.jl:2721
 [7] top-level scope
   @ stdin:4
in expression starting at /home/pkgeval/.julia/packages/ArrayLayouts/4IG3b/src/memorylayout.jl:712
in expression starting at /home/pkgeval/.julia/packages/ArrayLayouts/4IG3b/src/ArrayLayouts.jl:1
in expression starting at stdin:4

1.11 tests passed locally for me with this:

new in 0.4    |   61       1     62  9.6s
Test Summary: | Pass  Total  Time
einops comp   |   18     18  3.3s
     Testing TensorCast tests passed 

julia> VERSION
v"1.11.0-beta1"

Without this, the package gets an old version of ArrayLayouts which errors on testing 1.11:

```
Failed to precompile LazyArrays [5078a376-72f3-5289-bfd5-ec5146d43c02] to "/home/pkgeval/.julia/compiled/v1.11/LazyArrays/jl_XdUB8l".
ERROR: LoadError: too many parameters for type AbstractTriangular
Stacktrace:
 [1] top-level scope
   @ ~/.julia/packages/ArrayLayouts/4IG3b/src/memorylayout.jl:712
 [2] include(mod::Module, _path::String)
   @ Base ./Base.jl:558
 [3] include(x::String)
   @ ArrayLayouts ~/.julia/packages/ArrayLayouts/4IG3b/src/ArrayLayouts.jl:1
 [4] top-level scope
   @ ~/.julia/packages/ArrayLayouts/4IG3b/src/ArrayLayouts.jl:103
 [5] include
   @ ./Base.jl:558 [inlined]
 [6] include_package_for_output(pkg::Base.PkgId, input::String, depot_path::Vector{String}, dl_load_path::Vector{String}, load_path::Vector{String}, concrete_deps::Vector{Pair{Base.PkgId, UInt128}}, source::String)
   @ Base ./loading.jl:2721
 [7] top-level scope
   @ stdin:4
in expression starting at /home/pkgeval/.julia/packages/ArrayLayouts/4IG3b/src/memorylayout.jl:712
in expression starting at /home/pkgeval/.julia/packages/ArrayLayouts/4IG3b/src/ArrayLayouts.jl:1
in expression starting at stdin:4
```

1.11 tests passed locally for me with this:

```
new in 0.4    |   61       1     62  9.6s
Test Summary: | Pass  Total  Time
einops comp   |   18     18  3.3s
     Testing TensorCast tests passed 

julia> VERSION
v"1.11.0-beta1"
```
@mcabbott mcabbott merged commit 916fd68 into mcabbott:master Apr 22, 2024
3 of 4 checks passed
@mcabbott
Copy link
Owner

Thanks!

@KristofferC KristofferC deleted the patch-1 branch April 22, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants