Update for Base.stack, Julia 1.9
#14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcabbott
force-pushed
the
base_stack
branch
2 times, most recently
from
8f5793c to
74ce20c
Compare
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that JuliaLang/julia#43334 is merged, this (1) shouldn't export
stack, and (2) can deletestack_iterto use Base's better version.So the function is renamed to
lazystack. The qualifiedLazyStack.stackwill still work.Also (3) this removes all NamedDims connection. I wasn't using it and that package is no longer light-weight.
Closes #10, closes #9.
Oh I see I made an issue, #13. This PR does not add
dims.