Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of summaryComment on GitHub #314

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

VanRoy
Copy link
Contributor

@VanRoy VanRoy commented Mar 11, 2021

This pull request implement the support of the "Enable analysis summary under the GitHub Conversation tab" parameter for GitHub PullRequest analysis.

Screenshot of pull request comment submitted by SonarQube :

github-sonarqube-comment

Copy link
Owner

@mc1arke mc1arke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A couple of minor comments from me from a first read. I'll give it another check when I'm able to check-out the branch and run it.

@VanRoy VanRoy force-pushed the github-summary-comment branch 3 times, most recently from 4a8d637 to 6087f34 Compare March 17, 2021 20:36
@gnomeria
Copy link

Can't wait for this to be available. 🎉
Great job and thanks for the works

@VanRoy
Copy link
Contributor Author

VanRoy commented Mar 30, 2021

Can't wait for this to be available. 🎉
Great job and thanks for the works

Thanks @gnomeria . I'm currently work on an enhancement of this feature that hide previous outdated comments when you push new commits on existing Pull Request.

@sonarcloud
Copy link

sonarcloud bot commented Mar 30, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

94.5% 94.5% Coverage
0.0% 0.0% Duplication

@mc1arke mc1arke merged commit a8dca45 into mc1arke:master Mar 30, 2021
@mc1arke
Copy link
Owner

mc1arke commented Mar 30, 2021

Merged. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants