#309: Add support for Sonarqube 8.7 #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sonarqube 8.7 removed the concept of the `OrganizationDto` and removed the reference to this class in the `BranchSupportDelegate` interface, so the `CommunityBranchSupportDelegate` implementation has had to update the relevant method signature, therefore making this version of the plugin binary incompatible with older versions of Sonarqube. Alongside this, various webservice endpoints for configuring the global ALM definitions have been moved into the Community edition from the commercial Sonarqube editions, so have been removed from this plugin to prevent the bundled definitions conflicting with the plugin versions. As Sonarqube Community Edition now has direct UI options for configuring Bitbucket Cloud, the relevant endpoints have been introduced for supporting this UI, and the Bitbucket Cloud client used for Pull Request decorating has been updated to use OAuth 2 credential negotiation for authenticating, rather than using the Basic authentication previously used on all requests.
|
Kudos, SonarCloud Quality Gate passed! |
|
For anyone wanting to test this change, the build of the last pipeline is available by clicking the |
|
Hi @mc1arke , I tested the 1.7.0-SNAPSHOT plugin with Sonarqube 8.7 and it worked normally using the GITLAB integration. Pull Request Decoration and Project Import - OK Thank you for your excellent work on this plugin. 😄 |
|
I have tested also. Used below variables in different ways(as parameter, inside build.gradle file, as global variable ). Same Error. |
|
@alekberovvusal Can you check your CE log, as you're likely to have an exception logged just before that error. I suspect you're targeting a branch that sonarqube hasn't scanned yet, so it's failing to resolve it: The error handling could be better here, but it's not a new issue in this release. |
|
No problem with the master version. ;) Thx |
|
@mc1arke Thanks, will there be a 'official' release for 8.7 anytime soon? Otherwise I'll have to revert to a manual build which I'd rather not do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sonarqube 8.7 removed the concept of the
OrganizationDtoand removed the reference to this class in theBranchSupportDelegateinterface, so theCommunityBranchSupportDelegateimplementation has had to update the relevant method signature, therefore making this version of the plugin binary incompatible with older versions of Sonarqube.Alongside this, various webservice endpoints for configuring the global ALM definitions have been moved into the Community edition from the commercial Sonarqube editions, so have been removed from this plugin to prevent the bundled definitions conflicting with the plugin versions.
As Sonarqube Community Edition now has direct UI options for configuring Bitbucket Cloud, the relevant endpoints have been introduced for supporting this UI, and the Bitbucket Cloud client used for Pull Request decorating has been updated to use OAuth 2 credential negotiation for authenticating, rather than using the Basic authentication previously used on all requests.