Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send total coverage back to GitLab instead of new coverage #225

Merged
merged 1 commit into from
Mar 6, 2021

Commits on Aug 6, 2020

  1. Send total coverage back to GitLab instead of new coverage

    The coverage send back via the GitLab API should be the total coverage
    of the project, not the coverage of the new code in the PR. The GitLab
    docs explicitly mention this:
    https://docs.gitlab.com/ee/api/commits.html#post-the-build-status-to-a-commit
    
    The coverage reported by decorating the PR via a comment is not affected;
    this still shows both the total and new coverage.
    
    Note that there is an open GitLab issue for natively displaying new coverage
    for just the diff of a PR (https://gitlab.com/gitlab-org/gitlab/-/issues/20895),
    but this is not yet implemented.
    
    In addition, reporting coverage back is optional. So if there is no coverage
    information, we do not report it back.
    Teake Nutma committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    bfcbbd2 View commit details
    Browse the repository at this point in the history