Wrong Gitlab API url for MR decoration

[Brightside56]

Hello. First of all, thanks for a good job.

I've compiled jar from here:

https://github.com/mc1arke/sonarqube-community-branch-plugin/tree/sq-8_1-support

and when it comes publishing MR comment, plugin fails to do that. I'm seeing following in console:

GET /api/v4/api/v4/projects/root%2Fsonarqube/merge_requests/13/commits

As I see plugin gets hostURL with /api/v4, but also adds its own /api/v4 to url

[mc1arke]

Firstly, can you confirm this is the latest version of that branch you're using (the one that was published on Sunday)?

Can you also confirm how the host URL is being submitted? Is this auto-detected from the Gitlab CI environment by the Sonar Runner, of a property that you're passing as part of the launch arguments for the scanner?

[Brightside56]

Hello. Yes, it's last commit, you can see my git output below:

brightside@hp ~/git/sonarqube-community-branch-plugin
% git fetch origin
brightside@hp ~/git/sonarqube-community-branch-plugin
% git pull
Already up to date.
brightside@hp ~/git/sonarqube-community-branch-plugin
% git status
On branch sq-8_1-support

It seems to be autodetected. I'm running gitlab-ci ce pipeline this way:

• sonar-scanner -Dsonar.qualitygate.wait=true -Dsonar.projectKey=sonatest -Dsonar.pullrequest.key=$CI_MERGE_REQUEST_ID -Dsonar.pullrequest.branch=$CI_MERGE_REQUEST_TARGET_BRANCH_NAME -Dsonar.pullrequest.base=$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME

[mc1arke]

Ok. We're auto-detecting it from the CI pipeline variables then. I'll update the Gitlab decorator to not include the /api/v4 in the URL, and make sure it's clear to users that they need to include this if manually specifying it from the command line

[Brightside56]

After removing /api/v4 from URL it's working great with gitlab

[mc1arke]

Fixed in #87