Security hotspot link for Sq 8.5

[rockmagic]

Describe the bug

In sq 8.5 security hotspots are not listed among all issues, so the link "View in SonarQube" in MR comment leads to empty issues page with notice:

Cannot open selected issue, as it's not part of the initial 1000 loaded issues.

To Reproduce
Steps to reproduce the behavior:

1. Set up pull-request decoration for GitLab
2. Run scanner for merge request with security problem, for example hardcode something like password = "Password"
3. Go to Merge request, find the comment for this line, clink link "View in SonarQube"

Incorrect link:

https://sq.domain.name/project/issues?id=my%3Aproject&pullRequest=123&issues=AXX-ZP-9j1WiQQuk1P3v&open=AXX-ZP-9j1WiQQuk1P3v

Expected behavior
Link should head to Security Hotspots page in SonarQube

Corrent link:

https://sq.domain.name/security_hotspots?id=my%3Aproject&pullRequest=123&hotspots=AXX-UssNj1WiQQuk1If0

Screenshots

Software Versions

• SonarQube Version: Version 8.5 (build 38104)
• Plugin Version: 1.6.0

[mc1arke]

Can you provide a screenshot of the reported issue in GitLab please?

[rockmagic]

Sure, here's the discussion thread created by PR decoration:

[rockmagic]

sonarqube-community-branch-plugin/src/main/java/com/github/mc1arke/sonarqube/plugin/ce/pullrequest/AnalysisDetails.java

Line 119 in d5232b4

public String getIssueUrl(String issueKey) {

Maybe AnalysisDetails::getIssueUrl should receive whole issue object, or additional parameter to discover issue type.

[mc1arke]

Released in v1.9.0 of the plugin

[mc1arke]

Backported to 1.8.1 of the plugin for Sonarqube 8.9 support.