Rework protobuf representation of mutation tree #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid a restriction of the protobuf library that limits the recursion depth of a protobuf message, this change reworks the way the mutation tree is represented in protobuf format. The tree is now organised as a flat list of nodes, and the children of a node are identified via indices into this list. Fixes #192.
|
@JamesLee-Jones This reworking turned out to be reasonably straightforward, so - assuming that this solves the problems that you and @JonathanFoo0523 encountered - I think it's better to go this route rather than trying to upstream work-arounds to protobufs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid a restriction of the protobuf library that limits the
recursion depth of a protobuf message, this change reworks the way the
mutation tree is represented in protobuf format. The tree is now
organised as a flat list of nodes, and the children of a node are
identified via indices into this list.
Fixes #192.