Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect mutation of comma expressions in C++ #238

Merged
merged 5 commits into from
Jul 8, 2024
Merged

Fix incorrect mutation of comma expressions in C++ #238

merged 5 commits into from
Jul 8, 2024

Conversation

JamesLee-Jones
Copy link
Collaborator

No description provided.

@JamesLee-Jones JamesLee-Jones requested a review from afd May 30, 2024 17:29
@JamesLee-Jones JamesLee-Jones linked an issue Jun 4, 2024 that may be closed by this pull request
Copy link
Member

@afd afd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - a very small change to a comment requested.

src/libdredd/src/mutation_replace_expr.cc Outdated Show resolved Hide resolved
src/libdredd/src/mutation_replace_expr.cc Show resolved Hide resolved
@JamesLee-Jones JamesLee-Jones requested a review from afd July 5, 2024 12:35
Copy link
Member

@afd afd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@afd afd merged commit 7064f1c into main Jul 8, 2024
9 checks passed
@afd afd deleted the issue237 branch July 8, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect mutation of direct initialization with comma
2 participants